ec2_launch_template - scrub None parameters from what we'll pass to create_launch_config #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
This was referenced Feb 22, 2021
|
didn't work for me. While #438 does. |
|
@stefanhorning did you test it together with ansible-collections/amazon.aws#262, or did you just test this PR individually? (If the latter, it is not surprising at all that it didn't work.) |
|
Ah, no I missed that. Sorry. |
…reate_launch_config
tremble
force-pushed
the
ec2_launch_template/network
branch
from
32715c4 to
df3545b
Compare
tremble
changed the title
ansibullbot
added
community_review
integration
tremble
force-pushed
the
ec2_launch_template/network
branch
from
df3545b to
7631a6d
Compare
felixfontein
approved these changes
Mar 15, 2021
|
Has tests (which fail prior to the change) and a peer review. Merging |
danquixote
pushed a commit
to danquixote/community.aws
that referenced
this pull request
May 16, 2021
…reate_launch_config (ansible-collections#413) * ec2_launch_template - scrub None parameters from what we'll pass to create_launch_config * tests * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…reate_launch_config (ansible-collections#413) * ec2_launch_template - scrub None parameters from what we'll pass to create_launch_config * tests * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…reate_launch_config (ansible-collections#413) * ec2_launch_template - scrub None parameters from what we'll pass to create_launch_config * tests * changelog
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…reate_launch_config (ansible-collections#413) * ec2_launch_template - scrub None parameters from what we'll pass to create_launch_config * tests * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
tests: disable ec2_instance for now Depends-On: ansible/ansible-zuul-jobs#1005 SUMMARY Disable ec2_instance until we land: ansible-collections#411 ansible-collections#406 and figure out how to improve the reliabilty of the test. e.g of failure: https://890aa13aa78f6724352d-5fecf071b6e8bbf9bfb6df76861c0c6d.ssl.cf1.rackcdn.com/406/8f3c9c688f226433b44c0f21c738cf79190f49f4/check/ansible-test-cloud-integration-aws-py36_1/131d33e/job-output.txt ISSUE TYPE Bugfix Pull Reques COMPONENT NAME tests Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Because we now define suboptions for network configuration we need to make sure that when some of them are None we remove them.
Depends on: ansible-collections/amazon.aws#262
ISSUE TYPE
COMPONENT NAME
ec2_launch_template
ADDITIONAL INFORMATION
todo: